Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HIVE-28237: Add a default tez-site.xml to data/conf #5228

Closed
wants to merge 1 commit into from
Closed

HIVE-28237: Add a default tez-site.xml to data/conf #5228

wants to merge 1 commit into from

Conversation

abstractdog
Copy link
Contributor

@abstractdog abstractdog commented Apr 30, 2024 •
edited
Loading

What changes were proposed in this pull request?

Added a tez-site.xml file to data/conf: symlinked from data/conf/tez and added a typical test scenario setting as below:

  <property>
    <name>tez.local.mode</name>
    <value>true</value>
  </property>

Why are the changes needed?

As described on jira, users of StartMiniHS2Cluster might find it confusing where to set tez configs, not even defined without this patch.

Does this PR introduce any user-facing change?

No.

Is the change a dependency upgrade?

No.

How was this patch tested?

With StartMiniHS2Cluster, tez.local.mode=true was kicking in with the patch, this log line below was found in the log file of StartMiniHS2Cluster, so it created a LocalClient as expected

2024-04-30T02:55:14,168  INFO [DAGAppMaster Thread] client.LocalClient: Using working directory: /tmp/hive/scratch/laszlobodor/_tez_session_dir/7c9b847c-9d48-469a-a1e7-fa4d29b3148f/.tez/application_1714470913855_0001_wd

@aturoczy
Copy link

aturoczy commented Apr 30, 2024 •
edited
Loading

Is it a copy or a move? As a copy won't be better to reference to the original path? Just for the sake of file duplication.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@abstractdog
Copy link
Contributor Author

Is it a copy or a move? As a copy won't be better to reference to the original path? Just for the sake of file duplication.

copy + added an extra opt, I can experiment with adding it to the original file and making a symlink
in the mean I have to handle test failures

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 1, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Feel free to reach out on the dev@hive.apache.org list if the patch is in need of reviews.

@github-actions github-actions bot added the stale label Jul 1, 2024
@github-actions github-actions bot closed this Jul 9, 2024
@abstractdog
Copy link
Contributor Author

cannot reopnen, moving to #5348

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
stale tests failed
Projects
None yet
Milestone
No milestone
3 participants
@abstractdog @aturoczy @asf-ci-hive